Added support for Phonetic Matching #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
hualoqueros
approved these changes
Nov 30, 2020
ashtul
approved these changes
Nov 30, 2020
ashtul
approved these changes
Nov 30, 2020
| SetReturnFields("name")) | ||
|
|
||
| // Verify that the we've received 2 documents ( Jon and John ) | ||
| fmt.Printf("Total docs replied %d\n", total) |
There was a problem hiding this comment.
Why print and not assert?
There was a problem hiding this comment.
@MeirShpilraien this is an example. We're supposed to print and check the output matches. This is ment for godoc:
// Verify that the we've received 2 documents ( Jon and John )
fmt.Printf("Total docs replied %d\n", total)
// Output: Total docs replied 2
Expected godoc ( check output field):
| @@ -60,6 +60,8 @@ func TestSerializeSchema(t *testing.T) { | |||
| {"default-and-text", args{NewSchema(DefaultOptions).AddField(NewTextField("text-field")), redis.Args{}}, redis.Args{"SCHEMA", "text-field", "TEXT"}, false}, | |||
| {"default-and-sortable-text-field", args{NewSchema(DefaultOptions).AddField(NewSortableTextField("text-field", 10)), redis.Args{}}, redis.Args{"SCHEMA", "text-field", "TEXT", "WEIGHT", float32(10.0), "SORTABLE"}, false}, | |||
| {"default-and-text-with-options", args{NewSchema(DefaultOptions).AddField(NewTextFieldOptions("text-field", TextFieldOptions{Weight: 5.0, Sortable: true, NoStem: false, NoIndex: false})), redis.Args{}}, redis.Args{"SCHEMA", "text-field", "TEXT", "WEIGHT", float32(5.0), "SORTABLE"}, false}, | |||
| {"default-and-text-with-phonetic-en", args{NewSchema(DefaultOptions).AddField(NewTextFieldOptions("text-field", TextFieldOptions{PhoneticMatcher: PhoneticDoubleMetaphoneEnglish})), redis.Args{}}, redis.Args{"SCHEMA", "text-field", "TEXT", "PHONETIC", "dm:en"}, false}, | |||
| {"default-and-text-with-phonetic-pt", args{NewSchema(DefaultOptions).AddField(NewTextFieldOptions("text-field", TextFieldOptions{PhoneticMatcher: PhoneticDoubleMetaphonePortuguese})), redis.Args{}}, redis.Args{"SCHEMA", "text-field", "TEXT", "PHONETIC", "dm:pt"}, false}, | |||
There was a problem hiding this comment.
What those are used for?
There was a problem hiding this comment.
to test the internal schema serialization.
MeirShpilraien
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #87 by adding
PhoneticMatcherTypeproperty to text fields.It includes a new example to demonstrate phonetic matching features ( example name
ExampleClient_CreateIndexWithIndexDefinition_phonetic)