Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewSchema ignores opts arg #56

Closed
kind84 opened this issue Apr 11, 2020 · 3 comments · Fixed by #58
Closed

NewSchema ignores opts arg #56

kind84 opened this issue Apr 11, 2020 · 3 comments · Fixed by #58
Assignees
@filipecosta90
Labels
bug

Comments

@kind84
Copy link

kind84 commented Apr 11, 2020

redisearch-go/redisearch/schema.go

Line 165 in 76b1c66

Fields: []Field{},

That's why my options were not working 😅
@filipecosta90 filipecosta90 self-assigned this Apr 12, 2020
@filipecosta90
Copy link
Collaborator

hi there @kind84 thanks for reporting it. Just confirmed that this is present across all released versions. We'll fix it and include proper testing to ensure it wont happen again :)

@filipecosta90 filipecosta90 mentioned this issue Apr 12, 2020
Merged
@filipecosta90
Copy link
Collaborator

@kind84 , the PR #58 should fix it 👍

@filipecosta90
Copy link
Collaborator

hi there @kind84 , version 0.9.2 has this fix in place :) Thanks for reporting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipecosta90 filipecosta90

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NewSchema fix and extended testing for SerializeSchema RediSearch/redisearch-go
2 participants
@filipecosta90 @kind84