Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeValue does not support long numeric type, eg: -7989522793807773965 #47

Open
jameycai opened this issue Nov 29, 2018 · 10 comments
Open

Comments

@jameycai
Copy link

jameycai commented Nov 29, 2018

RangeValue does not support long numeric. When does it support?

eg:

  1. query 19 bit long numeric , Values.eg(-7989522793807773965)
  2. query 13 bit milliseconds, Values.between(1531152000000, 1543507200000)
@gkorland
Copy link
Contributor

Are you referring to a RangeValue?

@jameycai
Copy link
Author

jameycai commented Dec 5, 2018

Yes!

@jameycai jameycai changed the title support query strings of long numeric type, eg: "-6210607116848360331" RangeValue does not support long numeric type, eg: -7989522793807773965 Dec 5, 2018
@gkorland
Copy link
Contributor

gkorland commented Dec 5, 2018

RediSearch currently supports up to 48bit values

@jameycai
Copy link
Author

jameycai commented Dec 6, 2018

Values.eg (or Values.between), only supports int numeric type , don't supports long numeric type?

eg: -7989522793807773965

@gkorland
Copy link
Contributor

gkorland commented Dec 6, 2018

The RediSearch server side is currently limited to double.
I opened a feature request on RediSearch see: RediSearch/RediSearch#557

@jameycai
Copy link
Author

jameycai commented Dec 6, 2018

Thank you!

This restriction has been limited to use, such as query time in milliseconds, and 19-bit integer numerical queries. There are many usage scenarios.

@gkorland
Copy link
Contributor

gkorland commented Dec 6, 2018

Is time the only case where you need 64bit long? We consider of adding a primitive Time type

@jameycai
Copy link
Author

jameycai commented Dec 6, 2018

I usually convert time to 13-bit milliseconds for storage.

@jameycai
Copy link
Author

jameycai commented Dec 6, 2018

Now, I use java UUID.randomUUID().getLeastSignificantBits() to produce long numeric Id.

@jameycai
Copy link
Author

@gkorland Can you add this feature in the next version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants