Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer review and branching model #1

Closed
AdeebNqo opened this issue May 20, 2015 · 4 comments
Closed

Peer review and branching model #1

AdeebNqo opened this issue May 20, 2015 · 4 comments

Comments

@AdeebNqo
Copy link

Hello,

I have a few suggestions.

Branching model

The status on the README file currently () says:

Implementing the image manager that will be responsible for viewing the possible image types and sizes

There is currently no code in the master branch. I would to suggest the adoption of a branching model. Specifically,
I suggest the one described int this article

Peer review

Can we also use a peer review system. I suggest gerrit since it allows github sign in.

UI

I do not understand what is going on with the Wireframes on the README. Can we please re-do them, and aim use
material design

@mhdatie
Copy link
Member

mhdatie commented May 20, 2015

They all seem good. I am willing to push the code but since you suggested the branching model, I will have to look at it or find another alternative. As for Gerrit, it's a great tool for pull requests, I will make sure this project adopts it.

The UI part in the README was an initial one and is just used for quick presentation, it has changed and there will be up to 6 different types of items (each with their own layout) when we list the data. Everything will be Material.

Please be aware that this will be a boilerplate for a single endpoint only and will be using up-to-date libraries and good documentation for anyone willing to adopt its structure or help simplify it.

I am willing to use the name Redgram for Reddit for my official app in the future.

@mhdatie
Copy link
Member

mhdatie commented May 25, 2015

@AdeebNqo added the source code

@AdeebNqo
Copy link
Author

I saw that, thanks. I am going to go over it when I get the chance. Please just create a dev branch so that we will work on it until we release something.

@mhdatie
Copy link
Member

mhdatie commented May 25, 2015

created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants