draft: resources-ktx: Make Text compatible with compose #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
force-pushed
the
feature/resources-compose-compat
branch
from
d63d844 to
0a38d78
Compare
osipxd
changed the title
osipxd
force-pushed
the
feature/resources-compose-compat
branch
from
0a38d78 to
685ef79
Compare
osipxd
force-pushed
the
feature/resources-compose-compat
branch
from
bec1260 to
68ec3e3
Compare
osipxd
force-pushed
the
feature/resources-compose-compat
branch
from
68ec3e3 to
6378839
Compare
Zestxx
approved these changes
Mar 31, 2022
|
Check is Stable/Immutable needed |
osipxd
commented
Apr 16, 2024
| @@ -0,0 +1 @@ | |||
| <manifest /> | |||
|
@sonulen, it would be great to add some notes about this change to CHANGELOG.md |
Also updated Readme Co-authored-by: Osip Fatkullin <[email protected]>
Also update changelog and readme
sonulen
force-pushed
the
feature/resources-compose-compat
branch
from
78367c0 to
5dbebb4
Compare
sonulen
reviewed
Apr 16, 2024
| dependencies { | ||
| api(jetbrains.kotlin.stdlib) | ||
| api(androidx.annotation) | ||
| api(projects.textvalue) |
There was a problem hiding this comment.
@osipxd this dependency is not nice.
and even if we delete the Replace's, it will still remain because of Fragment.getString(text: TextValue).
maybe make a textvalue-ktx module for views? 😔
There was a problem hiding this comment.
I think it's totaly OK
sonulen
changed the title
|
No longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Textrenamed toTextValueto remove conflict withTextcomposableresources-ktxandresources-commonget(Context)replaced withget(Resources)Resources.getString(TextValue)functionstringResource(TextValue)composable to get string in composable functionsTextValue(...)to simplify text value creationBetter to review commit-by-commit.
Closes #47