[RFR] Add regex capability to match_messages #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpapaioa
changed the title
tpapaioa
changed the title
tpapaioa
force-pushed
the
flash_messages
branch
8 times, most recently
from
9297383 to
f3fd98a
Compare
tpapaioa
force-pushed
the
flash_messages
branch
from
f3fd98a to
9975bfb
Compare
mshriver
approved these changes
Dec 2, 2019
| @@ -274,25 +274,55 @@ def dismiss(self): | |||
| message.dismiss() | |||
|
|
|||
| def match_messages(self, text=None, t=None, partial=False, inverse=False): | |||
| """ | |||
| Return a list of flash messages matching the specified alert text and type(s) | |||
tpapaioa
force-pushed
the
flash_messages
branch
from
9975bfb to
957893f
Compare
izapolsk
approved these changes
Dec 3, 2019
| if t is not None: | ||
| self.logger.info('%s match of the flash message %r of type %r', log_part, text, t) | ||
| log_inverse = "inverse " if inverse else "" | ||
| log_type = f", type: {t!r}" if msg_type else "" |
There was a problem hiding this comment.
@mshriver, are we going to stick to py 3.6+ ? I'm about usage of f-strings in public modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to pass a compiled regex as the 'text' parameter for the match_messages, assert_message, and assert_success_message methods of the FlashMessages class.
For example, when testing VM retirement using the 'Time Delay from Now' option, the selected month/week/day/hour time delay values will be added to the date/time at which the page was loaded. The resulting flash message from a successful save is of the form "Retirement date set to 12/19/19 18:31 UTC". But if the time changes from one minute to the next while navigating to the Set Retirement Date page, it is impossible to predict accurately whether the flash message will display a time delay calculated from one or the other minute. Now, with a test like the following,
a single assertion against a range of dates / flash message texts can be performed.
A couple other small changes:
1.) Fixed several typos in which log messages wrote 'Boostrap tree' instead of 'Bootstrap tree'.
2.) Changed the logging in match_messages somewhat to make it clearer and to indicate when the match is actually an inverse match.
3.) Also added a unit test file, test_flashmessages.py, which tests basic functionality of the FlashMessages methods read, assert_no_error, assert_message, assert_success_message, match_messages, and dismiss.