First attempt at second attempt to get Trusted Content configured. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
/ok-to-test |
Hyperkid123
reviewed
Apr 20, 2023
| "module": "./RootApp", | ||
| "routes": [ | ||
| { | ||
| "pathname": "/inventory" |
There was a problem hiding this comment.
This should be a full pathname to the location where the module should be mounted. I don't think /insights is the place. What is the URL to the page where these modules should be available at?
| { | ||
| "title": "Trusted Content", | ||
| "appId": "trust", | ||
| "href": "/trust" |
There was a problem hiding this comment.
Again this URL does not seems correct. The link href should include the module route.
Hyperkid123
force-pushed
the
main
branch
14 times, most recently
from
053c54c to
43bb32a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly, I have no idea what I'm doing here.