-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest file extension should be webmanifest not json #342
Comments
Hi, I haven't checked .webmanifest type but .json type work on android just fine :-) |
@mastakilla1983: @gemal Most probably opened this issue because of the
(from: https://sonarwhal.com/docs/user-guide/rules/rule-manifest-file-extension/#why-is-this-important) |
I get the point, thank you for reporting. @alrra You seem to be involved in this question. Quick question for you: as most web servers are not configured for the |
Successfully tested against Windows Chrome and Android Chrome. Deployed a minute ago. |
@phbernard Sorry for the delayed answer.
Browsers (e.g.: Chrome, Samsung Internet) that have support for the web app manifest file don't actually care about what media type the file is served with, they just download it and parse it as JSON.
👍 |
@alrra That's what I observed with Chrome. Thanks for the confirmation! |
The post OneSignal/OneSignal-Website-SDK#332 has some useful information on this subject. For easier content searching: site.manifest manifest.json |
I believe the correct extension for the manifest file is webmanifest and not json
https://developer.mozilla.org/en-US/docs/Web/Manifest
The text was updated successfully, but these errors were encountered: