Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exclusion of Build Ids #19

Open
RaphHaddad opened this issue Apr 22, 2015 · 5 comments
Open

Support exclusion of Build Ids #19

RaphHaddad opened this issue Apr 22, 2015 · 5 comments

Comments

@RaphHaddad
Copy link

I know 'inclusion' is already there. But if 'exclusion' of build Ids sounds like a good idea I can send through a pull request.

@mavadat
Copy link
Contributor

mavadat commented Apr 22, 2015

I'd up vote that feature. A close one is also inclusion of project rather
than build types. With TC now supporting sub projects it makes more sense
to categorise by projects and have build light monitor a category. This
reduces the need for both build-type specific inclusion and exclusions.

Logic is that if build light should monitor certain builds within project
but not other ones chances are a categorisation by sub-project is missing
in TeamCity that reflects the difference meaningfully.

On Wednesday, April 22, 2015, Raphael Haddad [email protected]
wrote:

I know 'inclusion' is already there. But if 'exclusion' of build Ids
sounds like a good idea i can send through a pull request.


Reply to this email directly or view it on GitHub
#19.

Cheers,
Jamal

@aaronpowell
Copy link
Contributor

Sure, send a PR

@RaphHaddad
Copy link
Author

@mavadat maybe make a new 'issue'?

@aaronpowell will do.

@mavadat
Copy link
Contributor

mavadat commented Apr 22, 2015

Raphael, it certainly is new issue however I was hopping it might supersede
current issue in hopefully more elegant way.

On Wednesday, April 22, 2015, Raphael Haddad [email protected]
wrote:

@mavadat https://github.com/mavadat maybe make a new 'issue'?

@aaronpowell https://github.com/aaronpowell will do.


Reply to this email directly or view it on GitHub
#19 (comment).

Cheers,
Jamal

@RaphHaddad
Copy link
Author

Hey JM. In this PR I will redactor some of the code that calls the TC API
in order to get this feature in with another PR.

Sent from Gmail Mobile
On 22 Apr 2015 11:42, "Jamal Mavadat" [email protected] wrote:

Raphael, it certainly is new issue however I was hopping it might supersede
current issue in hopefully more elegant way.

On Wednesday, April 22, 2015, Raphael Haddad [email protected]
wrote:

@mavadat https://github.com/mavadat maybe make a new 'issue'?

@aaronpowell https://github.com/aaronpowell will do.


Reply to this email directly or view it on GitHub
#19 (comment).

Cheers,
Jamal


Reply to this email directly or view it on GitHub
#19 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants