refactor(symbol-observable): bump up symbol-observable@1 #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking blocked, discussion to prevent accidental check in. |
|
The update to SystemJS builder is what solves the global build issues? |
|
I just did start this by updating dependency version, I don't think version bump makes strong differences but configuration itself (https://github.com/ReactiveX/rxjs/pull/1772/files#diff-2702a38df95d385d0d224c110f92758eR8) was way to solve issue. Maybe applying same config to existing version of builder would works, didn't test it though. |
|
System JS hurts my brain. |
|
This LGTM. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
with my ❤️ to @Blesh ...
symbol-observable@1systemjs-builder@latestwith updating breaking change to its apiRelated issue (if exists):
#1766
I've created this PR only for demonstrating based on #1766 , so feel freely close this after updating original one.
One thing I'm not sure is how to verify sanity of systemjs build with updated scripts.. /cc @robwormald also.