-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
var rx_tap instead of func rx_tap #27
Comments
I've actually tried using properties in extensions initially, but for some reason compiler was complaining :(, so I've said, what the hell, I'll just use functions. It looks like compiler isn't complaining in swift 1.2 and Xcode 6.3.2, so we can use properties wherever possible :) |
I'm willing to make this change if you want... but it's a breaking change. Let me know what you want to do. |
Ideally, I would always want to be backwards compatible, and will try to be. If there are some obvious mistakes in the API or ugly interface that could be easily improved, I would like to correct it as soon as possible (before there are tons of code that depend on it). I don't expect these changes will aggravate users, because they will make their code more clear, and they would just need to remove redundant (). If you want to help the project, go for it 👍 and make those changes. |
I have a consideration about this: we are in the early times of the project, breaking changes are always bad, but are tolerated in early stages. I would prefer to have a breaking change now, rather than in a year or so while using the framework in an app in production. |
Hey guys, I just started using this library and it looks like |
Hi, sorry, readme probably has stale information. |
Currently the library uses code like:
public func rx_text() -> Observable<String> { ... }
What would it take to convince you to use something like the below instead?
public var rx_text: Observable<String> { ... }
The text was updated successfully, but these errors were encountered: