Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaded Dependencies for Queues? #2964

Closed
benjchristensen opened this issue May 19, 2015 · 5 comments
Closed

Shaded Dependencies for Queues? #2964

benjchristensen opened this issue May 19, 2015 · 5 comments

Comments

@benjchristensen
Copy link
Member

Right now we pull in source code for performant queue implementations (such as here #2963 and here https://github.com/ReactiveX/RxJava/tree/1.x/src/main/java/rx/internal/util/unsafe).

I'd like to explore whether we can put a shaded dependency on things like JCTools (https://github.com/JCTools/JCTools) and Agrona (https://github.com/real-logic/Agrona) along with specific paths to classes we are interested in so we can:

  1. Not need to copy/paste
  2. Show proper attribution through dependencies rather than comments in code
  3. More easily pick up bug fixes
  4. Still only pick up the byte size we want rather than the full libraries
  5. Still remain a single-jar, zero dependency artifact when published to maven central
@zsxwing
Copy link
Member

zsxwing commented May 19, 2015

Looks Agrona requires JDK8

@benjchristensen
Copy link
Member Author

Ah yes you're right, only for v2 for Agrona then.

@benjchristensen benjchristensen added this to the 2.0 milestone Aug 28, 2015
@akarnokd
Copy link
Member

akarnokd commented Sep 3, 2015

I like JCTools but I also like customizing it for RxJava's needs (i.e., inlining or dropping certain parts of it).

@nitsanw
Copy link
Contributor

nitsanw commented Mar 2, 2016

is this not a duplicate of #1735 ?

@akarnokd
Copy link
Member

Closing as a duplicate of #1735 (the discussion is much longer there anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants