chore(bazel): allow downstream projects to omit //:node_modules #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
---3.6KB-green.svg?style=flat-square){kind=icon}
---0.1KB-green.svg?style=flat-square){kind=icon}
benlesh
approved these changes
Feb 15, 2018
|
Hey @kwonoj what's the process to get PRs merged? Do I just ping you like this? |
|
usually, we demand 2 reviewers approval. Seems Ben approved already, so I'll 🚢 |
|
Thanks, should I send a separate PR to get this on master for v6?
…On Thu, Mar 1, 2018 at 8:56 AM OJ Kwon ***@***.***> wrote:
Merged #3322 <#3322>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3322 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAC5I6LqFR1fjJ-GrTxy4N3vkFPxfXxEks5taCfOgaJpZM4SHFFn>
.
|
|
Oh, it was targeted for stable. If you are able to, appreciate for it. |
|
… On Thu, Mar 1, 2018 at 9:00 AM OJ Kwon ***@***.***> wrote:
Oh, it was targeted for stable. If you are able to, appreciate for it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3322 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAC5I6rH74K_nqATXCsE-YGeFOBc5Dijks5taCkVgaJpZM4SHFFn>
.
|
This was referenced Mar 19, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.