-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asap and AnimationFrame Schedulers execute synchronously #1814
Comments
trxcllnt
changed the title
Asap and AnimationFrame Scheduler execute synchronously
Asap and AnimationFrame Schedulers execute synchronously
Jul 9, 2016
trxcllnt
added a commit
to trxcllnt/rxjs
that referenced
this issue
Jul 9, 2016
…ross their respective async bou The AsapScheduler and AnimationFrameSchedulers were totally busted. My bad. Now they execute their scheduled actions in batches, but if actions reschedule while executing a batch, a new frame is requested for the rescheduled action to execute in. ReactiveX#1814
trxcllnt
added a commit
to trxcllnt/rxjs
that referenced
this issue
Jul 11, 2016
…ross async boundaries. The AsapScheduler and AnimationFrameSchedulers were totally busted. My bad. Now they execute their scheduled actions in batches, but if actions reschedule while executing a batch, a new frame is requested for the rescheduled action to execute in. Fixes ReactiveX#1814
trxcllnt
added a commit
to trxcllnt/rxjs
that referenced
this issue
Jul 11, 2016
…ross async boundaries. The AsapScheduler and AnimationFrameSchedulers were totally busted. My bad. Now they execute their scheduled actions in batches. If actions reschedule while executing a batch, a new frame is requested for the rescheduled action to execute in. This PR also simplifies the public `Scheduler` and `Action` APIs. Implementation details like the `actions` queue and `active` boolean are now on the concrete implementations, so it's easier for people to implement the Scheduler API. This PR also renames `FutureAction` -> `AsyncAction` to conform to the same naming convention as the rest of the Action types. Fixes ReactiveX#1814
trxcllnt
added a commit
to trxcllnt/rxjs
that referenced
this issue
Jul 11, 2016
…ross async boundaries. The AsapScheduler and AnimationFrameSchedulers were totally busted. My bad. Now they execute their scheduled actions in batches. If actions reschedule while executing a batch, a new frame is requested for the rescheduled action to execute in. This PR also simplifies the public `Scheduler` and `Action` APIs. Implementation details like the `actions` queue and `active` boolean are now on the concrete implementations, so it's easier for people to implement the Scheduler API. This PR also renames `FutureAction` -> `AsyncAction` to conform to the same naming convention as the rest of the Action types. Fixes ReactiveX#1814
trxcllnt
added a commit
to trxcllnt/rxjs
that referenced
this issue
Jul 11, 2016
…ross async boundaries. The AsapScheduler and AnimationFrameSchedulers were totally busted. My bad. Now they execute their scheduled actions in batches. If actions reschedule while executing a batch, a new frame is requested for the rescheduled action to execute in. This PR also simplifies the public `Scheduler` and `Action` APIs. Implementation details like the `actions` queue and `active` boolean are now on the concrete implementations, so it's easier for people to implement the Scheduler API. This PR also renames `FutureAction` -> `AsyncAction` to conform to the same naming convention as the rest of the Action types. Fixes ReactiveX#1814
trxcllnt
added a commit
to trxcllnt/rxjs
that referenced
this issue
Jul 12, 2016
…ross async boundaries. The AsapScheduler and AnimationFrameSchedulers were totally busted. My bad. Now they execute their scheduled actions in batches. If actions reschedule while executing a batch, a new frame is requested for the rescheduled action to execute in. This PR also simplifies the public `Scheduler` and `Action` APIs. Implementation details like the `actions` queue and `active` boolean are now on the concrete implementations, so it's easier for people to implement the Scheduler API. This PR also renames `FutureAction` -> `AsyncAction` to conform to the same naming convention as the rest of the Action types. Fixes ReactiveX#1814
trxcllnt
added a commit
to trxcllnt/rxjs
that referenced
this issue
Jul 13, 2016
…ross async boundaries. The AsapScheduler and AnimationFrameSchedulers were totally busted. My bad. Now they execute their scheduled actions in batches. If actions reschedule while executing a batch, a new frame is requested for the rescheduled action to execute in. This PR also simplifies the public `Scheduler` and `Action` APIs. Implementation details like the `actions` queue and `active` boolean are now on the concrete implementations, so it's easier for people to implement the Scheduler API. This PR also renames `FutureAction` -> `AsyncAction` to conform to the same naming convention as the rest of the Action types. Fixes ReactiveX#1814
benlesh
pushed a commit
that referenced
this issue
Jul 16, 2016
…ross async boundaries. (#1820) The AsapScheduler and AnimationFrameSchedulers were totally busted. My bad. Now they execute their scheduled actions in batches. If actions reschedule while executing a batch, a new frame is requested for the rescheduled action to execute in. This PR also simplifies the public `Scheduler` and `Action` APIs. Implementation details like the `actions` queue and `active` boolean are now on the concrete implementations, so it's easier for people to implement the Scheduler API. This PR also renames `FutureAction` -> `AsyncAction` to conform to the same naming convention as the rest of the Action types. Fixes #1814
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
RxJS version:
All
Code to reproduce:
Expand to see the example code or run it in esnextb.in here
Expected behavior:
The boxes should animate by repeated calls to
setImmediate
orrequestAnimationFrame
.Actual behavior:
They don't. Instead, one call to
setImmediate
orrequestAnimationFrame
happens, then the actions reschedule themselves synchronously.Additional information:
I've fixed this in a branch and will have a PR once I've worked out the performance regressions.
The text was updated successfully, but these errors were encountered: