fix(expand): Fix expand to stay open until the source Observable comp…

…letes.
ReactiveX · Sep 17, 2015 · 20ef785 · 20ef785
1 parent 4ad6797
commit 20ef785
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/spec/operators/expand-spec.js b/spec/operators/expand-spec.js
@@ -11,7 +11,7 @@ describe('Observable.prototype.expand()', function () {
       d: 4 + 4, // c + c,
       e: 8 + 8, // d + d
     }
-    var e1 = hot('a', values);
+    var e1 = hot('(a|)', values);
     /*
       expectation explanation: (conjunction junction?) ...
       
@@ -44,7 +44,7 @@ describe('Observable.prototype.expand()', function () {
       d: 4 + 4, // c + c,
       e: 8 + 8, // d + d
     }
-    var e1 = hot('a', values);
+    var e1 = hot('(a|)', values);
     var expected = '(abcde|)';
 
     expectObservable(e1.expand(function(x) {

diff --git a/src/operators/expand.ts b/src/operators/expand.ts
@@ -29,7 +29,7 @@ class ExpandOperator<T, R> implements Operator<T, R> {
 class ExpandSubscriber<T, R> extends Subscriber<T> {
   private index: number = 0;
   private active: number = 0;
-  private hasCompleted: boolean = true;
+  private hasCompleted: boolean = false;
   private buffer: T[];
 
   constructor(destination: Observer<T>, private project: (value: T, index: number) => Observable<R>,