Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating packages and headers to match new convention #89

Merged
merged 1 commit into from
Nov 27, 2014
Merged

Updating packages and headers to match new convention #89

merged 1 commit into from
Nov 27, 2014

Conversation

Dorvaryn
Copy link

Headers have changed and packages convention as well.
This is making sure the rxandroid-framework stays in line with those new conventions.

@mttkay
Copy link
Collaborator

mttkay commented Nov 26, 2014

👍

@@ -29,6 +27,7 @@

import rx.Observable;
import rx.Observer;
import rx.android.app.ReactiveDialog;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed.

@JakeWharton
Copy link
Contributor

Please don't put multiple disjoint commits in a single PR.

Headers have changed and packages convention as well.
This is making sure the rxandroid-framework stays in line with those new
conventions.
@Dorvaryn
Copy link
Author

@JakeWharton It was one commit the second one was simply a modification of the package name.
I was considering doing two PR's but since it is simply updating to fit new project style didn't think it was relevant.

JakeWharton added a commit that referenced this pull request Nov 27, 2014
Updating packages and headers to match new convention
@JakeWharton JakeWharton merged commit 6371010 into ReactiveX:0.x Nov 27, 2014
@JakeWharton
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants