Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate activity/fragment binding. #105

Closed
wants to merge 1 commit into from
Closed

Conversation

JakeWharton
Copy link
Contributor

Closes #95.

@dlew
Copy link
Collaborator

dlew commented Nov 29, 2014

👍

@mttkay
Copy link
Collaborator

mttkay commented Nov 29, 2014

I don't think we can remove this until we introduce a variant of
HandlerThreadScheduler that executes synchronously when already on the main
thread. There were multiple long wound discussions around this. The problem
is that OperatorObserveOn posts unsubscribe on the main looper, even when
it's already on the main thread. This means that between unsubscribing and
Android destroying the views a window of time opens where the subscriber
gets a notification but the fragment is detached.

I don't see how the new life cycle observable fixes that.

We shouldn't deprecate this unless there's a better alternative available.
On Nov 29, 2014 2:07 PM, "Daniel Lew" [email protected] wrote:

[image: 👍]


Reply to this email directly or view it on GitHub
#105 (comment).

@dpsm
Copy link
Contributor

dpsm commented Nov 29, 2014

@mttkay I thought we did auto unsubscribe when the lifecycle "closes" didn't we? I am not sure if we ever fixed this ReactiveX/RxJava#1292

@dlew
Copy link
Collaborator

dlew commented Nov 29, 2014

@mttkay Interesting. I'll have to think on it.

@JakeWharton
Copy link
Contributor Author

Cool. Closing to ensure discussion happens on the issue.

@JakeWharton JakeWharton deleted the jw/deprecate-party branch November 29, 2014 22:17
@dlew
Copy link
Collaborator

dlew commented Nov 30, 2014

@mttkay Do you have links to any of the previous discussions, so we don't rehash it? I'd like to read through them then try to figure out a way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants