LifecycleObservable not unsubscribing after mergeWith

[david-hoze]

Hi, I'm running this code (version 0.24)

System.out.println("testMergeLifecycleObservable -------------------------------");

Observable<Long> source1 =
        LifecycleObservable.bindActivityLifecycle(lifecycle(),
                Observable.interval(5,TimeUnit.SECONDS)
                        .doOnUnsubscribe(() -> {System.out.println("source1 unsubscribe");})
        );

Observable<Long> source2 =
        LifecycleObservable.bindActivityLifecycle(lifecycle(),
                Observable.interval(5,TimeUnit.SECONDS)
                        .doOnUnsubscribe(() -> {System.out.println("source2 unsubscribe");})
        );

source1.mergeWith(source2)
        .flatMap(e -> {return Observable.just(e.toString());})
        .doOnUnsubscribe(() -> {System.out.println("final observable unsubscribe");})
        .subscribe(System.out::println);

and getting this output (after rotating the screen in the middle):

testMergeLifecycleObservable -------------------------------
0
0
1
1
2
2
source1 unsubscribe
source2 unsubscribe
testMergeLifecycleObservable -------------------------------
0
0
1
1

which means that the observable after the flatMap operator was not unsubscribed from..

[JakeWharton]

LifecycleObservable has been removed for future releases as part of #172. While it might come back in some form, you're much better off either emitting specific events for the lifecycle or explicitly unsubscribing in the callback.