Another generic back button #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@timdorr thanks for merging this! If you still want one, I'm willing to add that deprecation warning with a little guidance |
This was referenced Feb 2, 2018
8 tasks
This was referenced Sep 22, 2018
1 task
1 task
This was referenced Jan 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up on #5094
The only thing I couldn't figure out was how to issue a deprecation warning and where. There aren't any deprecation warnings in the repo that I could see so please provide an example :)
As far as where to add the warning, the simple re-export doesn't afford for a place to add a deprecation warning that only effects AndroidBackButton. Perhaps adding back a file called AndroidBackButton.js that exports the functionality of BackButton.js with the warning?
Thanks!