Add ES6 module build #2530
Add ES6 module build #2530
Conversation
|
@mjackson Thoughts on this? Do you still want to hold off on adding this to the build? Seems like both the benefits and the drawbacks are correspondingly minor. |
| "build": "rimraf lib && babel ./modules -d lib --ignore '__tests__'", | ||
| "build": "npm run build-cjs && npm run build-es6", | ||
| "build-cjs": "rimraf lib && babel ./modules -d lib --ignore '__tests__'", | ||
| "build-es6": "rimraf es6 && babel ./modules -d es6 --blacklist=es6.modules --ignore '__tests__'", |
There was a problem hiding this comment.
Where do you get the --blacklist flag from? I don't see it in the docs.
There was a problem hiding this comment.
Basically, this is supposed to do all transpiling except for modules, right?
There was a problem hiding this comment.
The docs on the page now are for Babel 6. This is a Babel 5 option to disable a specific transform, per https://github.com/babel/babel.github.io/blob/862b43db93e48762671267034a50c30c00e433e2/docs/usage/options.md#options.
This is just making a build that is applying all of our normal Babel transforms, except for the ES6 module transform, leaving the import/export statements intact. It even properly transpiles the ES7 export extensions we use on index.js to be vanilla ES6.
There was a problem hiding this comment.
Exactly. It will look a little different with Babel 6, since --blacklist is gone there, and everything goes through plugins and presets, but it would thematically be very similar.
|
This has been open for a week or so now - should we move forward with this change, or drop this for the time being? On balance I think adding the ES6 module build adds enough value for our users to justify the additional configuration involved that this PR adds. (Please don't merge as-is, though - at least not with the commit comment the way it is.) |
taion
changed the title
|
Should this actually be |
|
Going to merge this shortly unless it turns out there's a good reason to bundle this build. |
|
Should be noted perhaps that webpack doesn't look up |
|
Fair point, but if it's an upstream issue, I think it's okay to wait for a bit before addressing. |
|
@taion Please get approval from either @ryanflorence or myself before merging stuff like this. Neither of us actually want an ES6 module build at this time. |
Closes #2524. Replaces #2523.
Don't merge this, it's just a strawman to show what we'd have to change.