Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier and eslint configuration #11

Closed
wants to merge 14 commits into from

Conversation

Bashamega
Copy link

Description

I have integrated prettier and eslint

Closes #10

What change does this PR introduce?

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD (updates related to the CI/CD process)
  • Documentation update (changes to docs/code comments)
  • Chore (miscellaneous tasks that do not fall into the above options)

What is the proposed approach?

Please give a short overview/explanation on the approach taken to resolve the issue(s).

Checklist:

  • The commit message follows our adopted guidelines
  • Testing has been done for the change(s) added (for bug fixes/features)
  • Relevant comments/docs have been added/updated (for bug fixes/features)

@PhuongHoang
Copy link
Contributor

It is a nitpick comment:

Please have two separate pull requests: one for just the config changes and another is for the file formatting change. This PR has so many changes that makes it very hard to know quickly which one is the config change and which one is the formatted changes.

@Bashamega
Copy link
Author

No problem

@Bashamega Bashamega closed this Aug 26, 2024
@Bashamega Bashamega mentioned this pull request Aug 26, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add Linter and formatter to the project
2 participants