Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(X / Twitter): FxTwitter share button #764

Closed
3 tasks done
FinecoFinit opened this issue Jun 14, 2023 · 12 comments
Closed
3 tasks done

feat(X / Twitter): FxTwitter share button #764

FinecoFinit opened this issue Jun 14, 2023 · 12 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@FinecoFinit
Copy link

Application

Twitter

Issue

Embed fixing

Patch

Use stock share button or add another one for fxtwitter/vxtwitter/etc

Motivation

Sharing with other networks should be granted to community

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@FinecoFinit FinecoFinit added the Feature request Requesting a new feature that's not implemented yet label Jun 14, 2023
@oSumAtrIX
Copy link
Member

FxTwitter id discontinued

@JodanJodan
Copy link

@oSumAtrIX fxTwitter changed hands over a year ago; it's actively developed, not discontinued.

@oSumAtrIX
Copy link
Member

I am not sure if you understood the repository you linked. The repository is not about a Twitter client.

@oSumAtrIX
Copy link
Member

Also, the repository is open-source, nor an Android application, which is why no patch is necessary

@JodanJodan
Copy link

JodanJodan commented Jun 18, 2023

Yes, I understand what the repository is, it's for the fxtwitter.com service the ticket creator is requesting a share button for in the official Twitter Android app. fxTwitter is a service that proxies and enriches Twitter embed metadata, not an Android application.

@oSumAtrIX
Copy link
Member

Then I am not sure why you think ReVanced can patch it, considering it is not an Android app.

@JodanJodan
Copy link

Ticket creator is requesting a patch in the Twitter Android app for a share button using fxtwitter.com links instead of twitter.com, not a patch for fxTwitter.

@oSumAtrIX oSumAtrIX reopened this Jun 18, 2023
@FinecoFinit
Copy link
Author

Also, there are more instances of fxtwitter like vxtwitter etc, just make the ability to change the link

@kairusds
Copy link

Other alternative links can also be vxtwitter.com and nitter.com

@FrozenAlex
Copy link
Contributor

nitter seems to be dead

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
@ThomasHineXYZ

This comment was marked as spam.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fxtwitter share button feat(X / Twitter): fxtwitter share button May 6, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(X / Twitter): fxtwitter share button feat(X / Twitter): FxTwitter share button May 6, 2024
@cyberboh
Copy link

This also can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

8 participants