Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YouTube - Spoof video streams): Resolve playback issues after changing from cellular to wifi #4277

Merged

Conversation

LisoUseInAIKyrios
Copy link
Contributor

Seems to fix playback issues that can happen after changing from cellular to wifi while the app is open.

Clearing the url query also seems to improve the first 10 second video quality of Shorts opened with the regular player. Without this change, the first 10 seconds of video regularly has very bad video quality (usually 360p but sometimes 240p). With this change the first 10 seconds is usually 480p or higher before it switches the full resolution after 10 seconds.

This PR also hides Android Creator from the spoof type menu, as it fails to play livestreams and it does not fall over to other clients. So it's better to use it only as a fallback option for children's videos that contain music (which no other client can play).

@Figim
Copy link

Figim commented Jan 8, 2025

WEB_REMIX and WEB_CREATOR are available in the clients. What are they like?

z-huang/InnerTune#1774

OR TVHTML5 client: z-huang/InnerTune@6b96b6d

@YT-Advanced
Copy link

WEB_REMIX and WEB_CREATOR are available in the clients. What are they like?

z-huang/InnerTune#1774

OR TVHTML5 client: z-huang/InnerTune@6b96b6d

These client require to decompile signatureCiphers

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit e93e1c8 into ReVanced:dev Jan 9, 2025
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/spoof_network_change branch January 9, 2025 17:09
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
## [5.8.2-dev.1](v5.8.1...v5.8.2-dev.1) (2025-01-09)

### Bug Fixes

* **YouTube - Spoof video streams:** Resolve playback issues after changing from cellular to wifi ([#4277](#4277)) ([e93e1c8](e93e1c8))

return UNREACHABLE_HOST_URI_STRING;
return originalUri.buildUpon().clearQuery().build().toString();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LisoUseInAIKyrios This is not a good change, because now YouTube servers are pinged. They are already being pinged twice at least, and adding a third time to it is not good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the network is changed from cellular to wifi while playing then playback can fail until the app is force closed or the network changes back to cellular.

Clearing the url parameters fixes the issue.

A less serious but annoying issue is Shorts in the regular player regularly use 240p or 360p for the first ten seconds, and this change seems to improve the quality a lot where most videos start at 480p or 720p before changing to full resolution.

I could not figure out any other way to fix these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants