Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(X / Twitter): 'Unlock downloads' fails to patch version 10.64.x and later #3777

Closed
3 tasks done
cyberboh opened this issue Oct 16, 2024 · 2 comments · Fixed by #3782 or #3724
Closed
3 tasks done

bug(X / Twitter): 'Unlock downloads' fails to patch version 10.64.x and later #3777

cyberboh opened this issue Oct 16, 2024 · 2 comments · Fixed by #3782 or #3724
Labels
Bug report Something isn't working

Comments

@cyberboh
Copy link

Bug description

The patch is fail to be applied.

Error logs

SEVERE: Unlock downloads failed:
app.revanced.patcher.patch.PatchException: Failed to resolve ShowDownloadVideoUpsellBottomSheetFingerprint
at app.revanced.util.BytecodeUtilsKt.getException(BytecodeUtils.kt:28)
at app.revanced.patches.twitter.interaction.downloads.UnlockDownloadsPatch.execute$patch(UnlockDownloadsPatch.kt:41)
at app.revanced.patches.twitter.interaction.downloads.UnlockDownloadsPatch.execute(UnlockDownloadsPatch.kt:44)
at app.revanced.patches.twitter.interaction.downloads.UnlockDownloadsPatch.execute(UnlockDownloadsPatch.kt:23)
at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:173)
at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Patcher.kt:205)
at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
at app.revanced.cli.command.PatchCommand$run$4$1$1.invokeSuspend(PatchCommand.kt:303)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280)
at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:302)
at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
at picocli.CommandLine.access$1500(CommandLine.java:148)
at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
at picocli.CommandLine.execute(CommandLine.java:2170)
at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

Solution

Update the patches for upcoming X/Twitter version starting 10.64.xx

Additional context

I report it early to get early fixes. To reduce spam bug reports about it.

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@cyberboh cyberboh added the Bug report Something isn't working label Oct 16, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug:(X/Twitter) 'Unlock downloads' failed in 10.64.xx version bug(X / Twitter): 'Unlock downloads' fails to patch version 10.64.x and later Oct 16, 2024
@FrozenAlex
Copy link
Contributor

FrozenAlex commented Oct 17, 2024

It seems like the string the fingerprint refers to is gone from the method, they removed variantToDownload string from variantToDownload.url and now it's just url

@cyberboh
Copy link
Author

It seems like the string the fingerprint refers to is gone from the method, they removed variantToDownload string from variantToDownload.url and now it's just url

Mind to open a PR, sir?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
2 participants