Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - hide info cards): Some info cards still show up (a/b test) #367

Closed
daveout opened this issue Sep 4, 2023 · 12 comments · Fixed by ReVanced/revanced-patches-template#3039 or ReVanced/revanced-patches-template#2929
Labels
Bug report Something isn't working

Comments

@daveout
Copy link

daveout commented Sep 4, 2023

Bug description

Example 1: pop-up appears at 0:30 (mobile only), see screenshot:
https://www.youtube.com/watch?v=pqCVMRcj_bc
265442969-16532604-0664-4ebc-be82-66a5de163252

Example 2: pop-up appears at 2:47 (mobile only), see screenshot:
https://www.youtube.com/watch?v=gvzC8MmC850
265443271-e5837397-a046-4258-a6b6-de78451f337a

Steps to reproduce

see bug description above.

Solution

fix info card visibility

@daveout daveout added the Bug report Something isn't working label Sep 4, 2023
@Domiiniik

This comment was marked as spam.

@daveout daveout changed the title bug: Some info cards still show up bug (YouTube): Some info cards still show up Sep 6, 2023
@daveout

This comment was marked as off-topic.

@LisoUseInAIKyrios
Copy link
Contributor

I cannot reproduce, and info cards do not show up for those videos.

It might be an a/b test for a different implementation of info cards.

To confirm if it is an a/b test, try these steps and see if the issue is fixed:

  • turn on incognito mode
  • use a different YouTube account
  • turn on app spoofing

@daveout
Copy link
Author

daveout commented Sep 17, 2023

Yep they don't show up when in incognito mode. (both with app signature spoofing turned on and off).

@LisoUseInAIKyrios
Copy link
Contributor

Then it's an a/b test.

Signature spoofing wont fix it.

You can try turning on app spoofing (under Settings -> Layout), and that might fix it.
If you don't want an old UI, you can add an 18.x custom target using the instructions here

@daveout
Copy link
Author

daveout commented Sep 17, 2023

It worked perfectly. Thank you so much!

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug (YouTube): Some info cards still show up bug(YouTube - hide info cards): Some info cards still show up (a/b test) Sep 17, 2023
@n1cKz1
Copy link

n1cKz1 commented Sep 22, 2023

So i was about to create a new issue as i experienced the same thing before i found this one. The component name is apparently info_card_teaser_overlay.eml
Blocking that seems to do the job.

@HeroGalak
Copy link

So i was about to create a new issue as i experienced the same thing before i found this one. The component name is apparently info_card_teaser_overlay.eml
Blocking that seems to do the job.

Yes but it blocks also the related video panel when you swipe up in landscape

@LisoUseInAIKyrios
Copy link
Contributor

So i was about to create a new issue as i experienced the same thing before i found this one. The component name is apparently info_card_teaser_overlay.eml
Blocking that seems to do the job.

Yes but it blocks also the related video panel when you swipe up in landscape

Post the log statement that shows info_card_teaser_overlay.eml for the info cards, and the log statement for the related video panel.

@HeroGalak
Copy link

I think I've found the component name to block only info cards.

info_card_teaser_overlay.eml-js-canary

@LisoUseInAIKyrios
Copy link
Contributor

But what is the entire log string? The hide info cards patch can make additional specific checks that custom filter cannot.

@HeroGalak
Copy link

But what is the entire log string? The hide info cards patch can make additional specific checks that custom filter cannot.

I'm not so experienced with revanced development, but I can leave here the logs.

These are the logs when an infocard appears (no custom filtered):

27.09 11:25:42.710 10467 16992 16992 app.revanced.android.youtube D/revanced: LithoFilterPatch: Searching ID: info_card_teaser_overlay.eml-js-canary|b5143e0565b8b42a Path: info_card_teaser_overlay.eml-js-canary|b5143e0565b8b42a|ContainerType| 27.09 11:25:42.711 10467 16992 16992 app.revanced.android.youtube D/revanced: LithoFilterPatch: Searching ID: null Path: info_card_teaser_overlay.eml-js-canary|b5143e0565b8b42a|ContainerType|ContainerType| 27.09 11:25:42.712 10467 16992 16992 app.revanced.android.youtube D/revanced: LithoFilterPatch: Searching ID: null Path: info_card_teaser_overlay.eml-js-canary|b5143e0565b8b42a|ContainerType|ContainerType|ContainerType| 27.09 11:25:42.713 10467 16992 16992 app.revanced.android.youtube D/revanced: LithoFilterPatch: Searching ID: null Path: info_card_teaser_overlay.eml-js-canary|b5143e0565b8b42a|ContainerType|ContainerType|ContainerType|TextType| 27.09 11:25:42.714 10467 16992 16992 app.revanced.android.youtube D/revanced: LithoFilterPatch: Searching ID: null Path: info_card_teaser_overlay.eml-js-canary|b5143e0565b8b42a|ContainerType|ContainerType|ContainerType| 27.09 11:25:42.715 10467 16992 16992 app.revanced.android.youtube D/revanced: LithoFilterPatch: Searching ID: null Path: info_card_teaser_overlay.eml-js-canary|b5143e0565b8b42a|ContainerType|ContainerType|ImageType| 27.09 11:25:42.719 10467 16992 16992 app.revanced.android.youtube D/revanced: LithoFilterPatch: Searching ID: null Path: info_card_teaser_overlay.eml-js-canary|b5143e0565b8b42a|ContainerType|ContainerType|ContainerType|avatar.eml|7170e708ac9dccd7|ImageType|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
5 participants