Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDR unexpectedly back again #3452

Closed
3 tasks done
0xrxL opened this issue Jul 18, 2024 · 11 comments
Closed
3 tasks done

HDR unexpectedly back again #3452

0xrxL opened this issue Jul 18, 2024 · 11 comments
Labels
Bug report Something isn't working

Comments

@0xrxL
Copy link

0xrxL commented Jul 18, 2024

Bug description

Since client spoofing becomes a reality, the more stable spoof (iOS) didn't show HDR on quality menu...until now at least:

In short: I applied a patch to enable OPUS codec, created by @inotia00, and I unexpectedly noticed that HDR videos are played as expected:

Screenshot_20240718_205722

Oh...and these are my client model infos:

Screenshot_20240718_205550_Samsung Internet Beta

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@0xrxL 0xrxL added the Bug report Something isn't working label Jul 18, 2024
@oSumAtrIX
Copy link
Member

What fixes it is the header and not the patch

@0xrxL
Copy link
Author

0xrxL commented Jul 18, 2024

I don't know how HDR has been fixed on my side, so I posted the patch (which I currently use) as a possible fix, along with the client information I'm using.

@oSumAtrIX
Copy link
Member

As previously explained it can be fixed by using the expected IOS header in the player request. But there is no known way to change the header just for that request

@0xrxL
Copy link
Author

0xrxL commented Jul 18, 2024

As previously explained it can be fixed by using the expected IOS header in the player request. But there is no known way to change the header just for that request

It's already fixed for me, as I previously described.

Maybe you can try to check if it is fixed on your side too, with above infos. 🤷‍♂️

@zainarbani
Copy link
Contributor

zainarbani commented Jul 19, 2024

Your device support HWA AV1 decoding?

@0xrxL
Copy link
Author

0xrxL commented Jul 19, 2024

Your device support HWA AV1 decoding?

Yeah, but before now I wasn't able to enable HDR on videos.

For this reason I thought there is something of useful, that can be applied to stock ReVanced too.

@zainarbani
Copy link
Contributor

Thats actually bit strange since HDR video shouldn't be available unless you change the user-agent,
Can you show the stat for nerd when playing HDR videos?

@0xrxL
Copy link
Author

0xrxL commented Jul 19, 2024

Thats actually bit strange since HDR video shouldn't be available unless you change the user-agent, Can you show the stat for nerd when playing HDR videos?

I changed the user agent a month ago and only now I got HDR.

Maybe it's due to the new user agent I used?

Anyway you'll find my screenshots here

@zainarbani
Copy link
Contributor

zainarbani commented Jul 20, 2024

I try with iOS 15/16 and yeah only iOS 17 got HDR/AV1 format, youtube maybe changes something.

Prev test with iOS 15 is here

Im not iPhone user, but at least iPhone 12 up should support HDR right?

edit: googling and found that even iPhone X support HDR (?)

@0xrxL
Copy link
Author

0xrxL commented Jul 20, 2024

Im not iPhone user, but at least iPhone 12 up should support HDR right?

HDR is available starting from iPhone X, yeah, but I guess that codec wasn't aligned to a one compatible with Android...until now, with the new YouTube changes.

Therefore, user agent patch could become the next to be implemented.

@0xrxL
Copy link
Author

0xrxL commented Aug 6, 2024

#3468

@0xrxL 0xrxL closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants