Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Spoof client): Playback speed flyout menu is missing #3203

Closed
3 tasks done
MoTem opened this issue May 21, 2024 · 7 comments
Closed
3 tasks done

bug(YouTube - Spoof client): Playback speed flyout menu is missing #3203

MoTem opened this issue May 21, 2024 · 7 comments
Labels
Bug report Something isn't working

Comments

@MoTem
Copy link

MoTem commented May 21, 2024

Bug description

Playback speed button no longer shows up in the flyout menu. There is no way to change it currently other than by setting it in Revanced - Video - Default Playback Speed.

This issue appeared after updating from 4.7 to 4.8. No changes in default patches, and cache was cleared. The option to show playback speed was enabled and disabled too.

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@MoTem MoTem added the Bug report Something isn't working label May 21, 2024
@MoTem MoTem changed the title bug: Playback speed button is missing (Patches version 4.8) bug: Playback speed button is missing (Patch version 4.8) May 21, 2024
@LisoUseInAIKyrios
Copy link
Contributor

There is no playback speed button in the player.

Playback speed is in the flyout menu.

@LisoUseInAIKyrios LisoUseInAIKyrios closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
@MoTem
Copy link
Author

MoTem commented May 21, 2024

Yes I am aware of that. It is not appearing in the flyout menu, even when it is enabled. I am not the only one facing this issue, a lot of users mentioned this on reddit too.

@cyberboh
Copy link

Yes I am aware of that. It is not appearing in the flyout menu, even when it is enabled. I am not the only one facing this issue, a lot of users mentioned this on reddit too.

Turn off client spoof , restart app and check

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented May 21, 2024

I'm able to reproduce this just now. Flyout menu is missing the speed option, for both spoof client types.

The speed button on the "premium controls" (premium feature) is present, but it does nothing and opens an empty flyout menu.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug: Playback speed button is missing (Patch version 4.8) bug(YouTube - Spoof client): Playback speed flyout menu is missing May 21, 2024
@gui-lherme
Copy link

gui-lherme commented May 21, 2024

I'm experiencing this as well. When I turn off the client spoof patch, the playback speed flyout returns to normal. I'm using a brand account.
Edit: forgot to mention: I'm using non-root version.

@oSumAtrIX
Copy link
Member

This is one of the limitations we can work around with with #3197. I am not sure why the player request causes these issues because the player only returns player data and not layout instructions. What can be done is set the response type to json, check if it contains anything interesting in this regard. If it does not, that means we don't only touch /player requests. Perhaps YouTube is also caching objects so when we modify them with a hook, they may be used in a other request. Perhaps after the request is done, we could reset the fields we change and see if that makes a difference

@oSumAtrIX
Copy link
Member

Moving to #3208

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants