Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Disable resuming Shorts player): Patch does not always work with YT 19.04.37+ #2716

Closed
3 tasks done
cyberboh opened this issue Feb 12, 2024 · 9 comments · Fixed by #3629 or #3724
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@cyberboh
Copy link

Bug description

Whenever i open YT after closed it while playing Shorts video, the short it self is playing automatically. The Hide button Disable resuming Shorts player does not work.

Patched with CLI:

java -jar revanced-cli-4.4.0-all.jar patch -p -o Install\YouTube_19.04.37-all_ReVanced.apk --options options.json -b revanced-patches-4.3.0-dev.2.jar --alias=******** --keystore-password=*********** --keystore-entry-password=******** --keystore=********.keystore -m revanced-integrations-1.4.0-dev.2.apk Apps\com.google.android.youtube-19.04.37-all.apk -i "Change header"

How to reproduce:

  1. Enable Disable resuming Shorts player
  2. Playing some shorts
  3. Force stop YT (clear from recents)
  4. Open YT again
  5. Short will be playing

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@cyberboh cyberboh added the Bug report Something isn't working label Feb 12, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Feb 12, 2024

The patch is working for me.

The patch prevents resuming the Shorts player when the app is cold launched.

To verify this:

  • open ReVanced YT
  • open a Short
  • close the app
  • stop the app from running in the background
  • relaunch the app

If the patch is enabled, YT will launch and open the home feed.

If the patch is not enabled, the Shorts player will resume.

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Feb 12, 2024

If Shorts are resuming, then post a video showing the behavior.

@cyberboh
Copy link
Author

The patch prevents resuming the Shorts player when the app is cold launched.

To verify this:

* open ReVanced YT

* open a Short

* close the app

* stop the app from running in the background

* relaunch the app

If the patch is enabled, YT will launch and open the home feed.

If the patch is not enabled, the Shorts player will resume.

Patch is enabled, but YT is resuming shorts player

@cyberboh
Copy link
Author

If Shorts are resuming, then post a video showing the behavior.

file.mp4

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Feb 12, 2024

Are you sure the app was closed in the background?

Try turning on incognito mode and try again.

Also try turning on version spoofing with spoof target 18.09.39.

19.04.x has changes to the code for resuming Shorts. The patch is working for me, but maybe there is some new code that's enabled for some users.

@cyberboh
Copy link
Author

Are you sure the app was closed in the background?

Try turning on incognito mode and try again.

Also try turning on version spoofing with spoof target 18.09.39.

19.04.x has changes to the code for resuming Shorts. The patch is working for me, but maybe there is some new code that's enabled for some users.

I'm sure. In my device, clear recents is enough to force stopping all opened apps.

Turning on incognito and spoofing app to 18.09.39 is same, Shorts still resuming.

I'll try to patch 19.03.36 and see

@cyberboh
Copy link
Author

@LisoUseInAIKyrios YT 19.03.36 is fine though, the patch is working.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug: (YT 19.04.37) Disable resuming Shorts player does not work bug(YouTube): Disable resuming Shorts player does not work with YT 19.04.37 Feb 12, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube): Disable resuming Shorts player does not work with YT 19.04.37 bug(YouTube): Disable resuming Shorts player does not work with YT 19.04.37+ Feb 12, 2024
@oSumAtrIX
Copy link
Member

Does this issue still occur? I can not reproduce it.

@oSumAtrIX oSumAtrIX added the Waiting on author Further information is requested label Mar 12, 2024
@LisoUseInAIKyrios
Copy link
Contributor

@oSumAtrIX with 19.09 this is now showing up for me. It must be an a/b change to use new code for resuming Shorts.

@LisoUseInAIKyrios LisoUseInAIKyrios removed the Waiting on author Further information is requested label Mar 12, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube): Disable resuming Shorts player does not work with YT 19.04.37+ bug(YouTube - Disable resuming Shorts player): Patch does not always work with YT 19.04.37+ Jun 2, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios linked a pull request Sep 18, 2024 that will close this issue
@LisoUseInAIKyrios LisoUseInAIKyrios linked a pull request Oct 19, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
3 participants