Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve patch descriptions #2515

Closed
2 of 4 tasks
SyBEL34 opened this issue Dec 18, 2023 · 2 comments
Closed
2 of 4 tasks

feat: Improve patch descriptions #2515

SyBEL34 opened this issue Dec 18, 2023 · 2 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@SyBEL34
Copy link

SyBEL34 commented Dec 18, 2023

Feature description

Improve descriptions of patches to more clearer, informative ones.

Motivation

Currently, some of the patches revanced offers either have descriptions that are confusing, vague, or not very helpful in figuring out what it does. Some of it is due to generally lacking informative description, and other is due to terminology(referring to components that revanced patches, which may not known well to the public mass). This could lead users to miss out on certain patches they might want to use.

Additional context

Following are cases in patches for YouTube shown as examples.

e1. Unclear descriptions
Change start page
Changes start page of the app.
→ It does not specify what change it does to the start page and whether "start page" refers to the app intro that was recently added to the app or the main screen that comes after.
Hide layout components
Hides general layout components.
→It does not specify what "general layout components" referring here. This can be referring to literally anything in the app by description.

e2. Terminology/Wording problem
Player flyout menu
Hides flyout menu items.
→The fact that I had to search what "flyout menu" is showing a problem here. Even if it does describe what it patches over, sometimes it requires describing the features/components that getting patched first place(even if it sounds obvious). A good example here is the description of the patch Hide endscreen cards (Hides suggested video cards at end of videos.)
Premium Heading
Show or hide premium heading.
→Instead of using the word 'heading', 'logo' is way more straightforward to refer to it. Changing words to way more simple, straightforward ones helps users to understand. (Especially cases of international users who may have shortcomings in English skills, before full implementation of translations.)

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@SyBEL34 SyBEL34 added the Feature request Requesting a new feature that's not implemented yet label Dec 18, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-manager Dec 18, 2023
@oSumAtrIX
Copy link
Member

#1054

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2023
@KobeW50
Copy link
Contributor

KobeW50 commented Dec 20, 2023

Hello @SyBEL34! I recently opened a pull request to help resolve this issue. Please don't hesitate to look over the pull request and give feedback and suggestions.

As a side note, I don't think much can be done about the description of the Hide layout components patch since the variety of things it can hide is too wide to be summed up easily. However, at least now it will say that it "Adds options to hide general layout components." which means the user knows they will be able to see all the specific options within the patched app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants