Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube): Playback Speed button, drag slider, double-tap zones #1620

Closed
3 tasks done
Coldblackice opened this issue Dec 10, 2022 · 10 comments · Fixed by #3197 or #3266
Closed
3 tasks done

feat(YouTube): Playback Speed button, drag slider, double-tap zones #1620

Coldblackice opened this issue Dec 10, 2022 · 10 comments · Fixed by #3197 or #3266
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@Coldblackice
Copy link

Coldblackice commented Dec 10, 2022

Application

YouTube (com.google.android.youtube)

Issue

Currently, Playback-Speed control requires jumping into sub menus, necessitating multiple screen taps each time a speed change up or down or default is desired.

On desktops, keyboard shortcuts "<” and ">" change playback speed on the fly, but obviously this isn't practical on mobile devices.

Patch

To more quickly and directly change a video's playback speed, it would be fantastic if any of the following could be implemented:

  • Playback-Speed button added to on-video controls (👍, 👎, etc)
  • Playback-Speed drag-slider (like volume and brightness sliders)
  • Playback-Speed double-tap zones, double-tapping the top of a video increases speed, the bottom area decreases

A fine-grained speed scale wouldn't be necessary, even merely sliding between default .5x--1x--1.5x--2x would be phenomenal.

Motivation

Reason:

This patch would provide quick, direct access for a user to change playback-speed on the fly -- because some parts of a video might not be ideal at 2x, like technical explanations, while other parts could use a speed bump.

This optional patch for changing playback-speed via an on-video button, or drag-slider, or double-tap would cut out the need for multiple screen taps + sub menus each time a user wants to change speeds.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Coldblackice Coldblackice added the Feature request Requesting a new feature that's not implemented yet label Dec 10, 2022
@aronnoordhoek
Copy link

aronnoordhoek commented Dec 11, 2022

I just posted a similar idea on Reddit before seeing you had opened this. I had the idea to pair the speed adjustment dragging with scrubbing in a horizontal split just like the brightness-volume split.

The scrubbing could also be based on a setting so that people could choose to scrub normally or precisely/per frame.

Post: https://www.reddit.com/r/revancedapp/comments/zjb62l/idea_for_a_patch_the_blue_and_yellow_horizontal/
Image of idea: https://i.imgur.com/T3C7EPF.png

@nochlab1
Copy link

nochlab1 commented Jan 8, 2023

closing the other issue means that this idea is actually being done?

@oSumAtrIX
Copy link
Member

It means they both were duplicates of each other.

@nochlab1
Copy link

nochlab1 commented Jan 8, 2023

oh i got excited

@Bluscream
Copy link

same here

@nightgolfer
Copy link

Is this still not a thing? Seems like such an easy QOL improvement, really wish there was an simple way to change playback speed without having to go into menus. I have volume buttons on my phone, let me scrub playback speed instead, please. Or a dedicated button, that would also be fine. Anything to avoid having to go through multiple menus 😳

Tap video for controls. Tap settings icon. Tap playback speed setting. Tap desired speed. 😮‍💨

@oSumAtrIX oSumAtrIX changed the title feat(patch): "Playback Speed" button || drag-slider || double-tap zones feat(patch): Playback Speed button, drag slider, double-tap zones Aug 19, 2023
@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
@megamorphg
Copy link

I switch between 1x and 2x speed pretty frequently (some videos just have to be watched on either speed).
One way to implement this is to have custom-defined buttons on the overlay like the browser script has.

@mizoru

This comment was marked as spam.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(patch): Playback Speed button, drag slider, double-tap zones feat(YouTube): Playback Speed button, drag slider, double-tap zones Apr 2, 2024
@megamorphg
Copy link

megamorphg commented Jun 3, 2024

@oSumAtrIX The 1st part of this request is complete, but there are two other bullets which could simply be addressed: would it be possible to make it so that holding the speed button toggles to the last used speed? (Kind of like the "hold the copy URL button to copy with the timestamp.")

It already is a big improvement but this would be a huge improvement further not to have a dialog to have to click through... since it is common to switch back and forth from 1x to a faster speed pretty often for a lot of people,

@Bluscream

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
8 participants