Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem: hdr-max-brightness Patch broken with latest swipe-controls rewrite #2371

Closed
TheJeterLP opened this issue Jul 11, 2022 · 3 comments
Closed
Labels
Bug report Something isn't working

Comments

@TheJeterLP
Copy link

TheJeterLP commented Jul 11, 2022

🐞 Issue

Auto setting the brightness to 100% for HDR videos no longer works.

βš™ Reproduce

Build ReVanced using the currently available latest versions.

πŸ›  Solution

Further debugging

@shadow578
Copy link
Contributor

Seems like it interacts with the swipe-controls patch in a way i didn't notice while rewriting that one.
Will work on a fix asap

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jul 11, 2022

Please mind, the patches should not conflict each other if possible. Create a dependency patch which handles the stuff which swipe-controls and hdr-max-brightness do. The dependency can then simply feature an addHook(to) method which both patches can call independently, while the dependency manages how it inserts the hook to the required method.

@shadow578
Copy link
Contributor

Please mind, the patches should not conflict each other if possible. Create a dependency patch which handles the stuff which swipe-controls and hdr-max-brightness do. The dependency can then simply feature an addHook(to) method which both patches can call independently, while the dependency manages how it inserts the hook to the required method.

interactions are limited to within interactions, so there shouldn't be any issues

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@alexandreteles alexandreteles transferred this issue from another repository Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants