Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Suggest version after selection of patches #2310

Open
3 tasks done
oSumAtrIX opened this issue Nov 12, 2024 · 2 comments
Open
3 tasks done

bug: Suggest version after selection of patches #2310

oSumAtrIX opened this issue Nov 12, 2024 · 2 comments
Assignees
Labels
Bug report Something isn't working

Comments

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Nov 12, 2024

Bug description

Currently, the suggested version is listed in the app selector screen. Instead, the flow should be like this:

  1. User opens app selector and selects an app
  2. The patch selector screen opens where the user can select a list of patches. If default is forced, then skip this step
  3. Based on the current selection, the version of the selected app is checked. If it matches, skip this step. If it does not match, show a dialog that shows the suggested version based on that selection and offers to choose the APK from storage. (Since APKs can be split, the dialog should also ask to select from storage due to the app being split too, like it is now)
  4. After that, the user lands back on the patcher screen and can start patching

Motivation

Depending on your patch selection, the suggested version may be different. For example, you select patches that work with any app, and uncheck one that only works on a specific version. ReVanced Manager would suggest that one, even if you don't use the patch.

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager.
@oSumAtrIX oSumAtrIX added the Feature request Requesting a new feature that's not implemented yet label Nov 12, 2024
@oSumAtrIX oSumAtrIX added Bug report Something isn't working and removed Feature request Requesting a new feature that's not implemented yet labels Nov 12, 2024
@KobeW50
Copy link
Contributor

KobeW50 commented Nov 12, 2024

The motivation makes sense, but i think this will cause confusion for users, since many people will have different suggested versions.

Furthermore, this may cause users to download more APKs than previously since the suggested version can change just by changing the patch selection

@TheAabedKhan TheAabedKhan changed the title feat: Suggest version after selection of patches bug: Suggest version after selection of patches Nov 12, 2024
@oSumAtrIX
Copy link
Member Author

oSumAtrIX commented Nov 12, 2024

Users are suggested to use the recommended selection. Those who change it will potentially see a different suggested version based on their selection. The version must be calculated from the selection, not doing it is not an option and a severe problem as seen with the Twitter patches suggesting a version based on a single patch that is disabled by default, but making users download an old version which breaks one of the patches intended for the late versions.

Users don't have to download "more" APKs. You patch once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants