From 06db8f4d7d827b0589db99b31fefdf26605e5d4f Mon Sep 17 00:00:00 2001 From: Alex Uskov Date: Tue, 8 Oct 2024 19:46:18 +0400 Subject: [PATCH 1/4] feat(Twitter - Replace Sharing Domain): Initial commit --- .../links/ChangeLinkSharingDomainPatch.java | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java diff --git a/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java b/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java new file mode 100644 index 0000000000..153ffe3061 --- /dev/null +++ b/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java @@ -0,0 +1,21 @@ +package app.revanced.integrations.twitter.patches.links; + +public final class ChangeLinkSharingDomainPatch { + static final String DOMAIN_NAME = "https://fxtwitter.com"; + static final String LINK_FORMAT = "%s/%s/status/%s"; + + public static String formatResourceLink(Object... formatArgs) { + String username = (String) formatArgs[0]; + String tweetId = (String) formatArgs[1]; + return formatSharingLink(tweetId, username); + } + + public static String formatLink(long tweetId, String username) { + String tweetIdStr = Long.toString(tweetId); + return formatSharingLink(tweetIdStr, username); + } + + private static String formatSharingLink(String tweetId, String username) { + return String.format(LINK_FORMAT, DOMAIN_NAME, username, tweetId); + } +} From 62c798d78d0c84de65b1e62a9cf87578dff511d9 Mon Sep 17 00:00:00 2001 From: Alex Uskov Date: Fri, 11 Oct 2024 12:22:38 +0400 Subject: [PATCH 2/4] feat(Twitter - Replace Sharing Domain): Simplify integration code --- .../patches/links/ChangeLinkSharingDomainPatch.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java b/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java index 153ffe3061..b242571ab2 100644 --- a/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java +++ b/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java @@ -7,15 +7,11 @@ public final class ChangeLinkSharingDomainPatch { public static String formatResourceLink(Object... formatArgs) { String username = (String) formatArgs[0]; String tweetId = (String) formatArgs[1]; - return formatSharingLink(tweetId, username); + return String.format(LINK_FORMAT, DOMAIN_NAME, username, tweetId); } public static String formatLink(long tweetId, String username) { String tweetIdStr = Long.toString(tweetId); - return formatSharingLink(tweetIdStr, username); - } - - private static String formatSharingLink(String tweetId, String username) { - return String.format(LINK_FORMAT, DOMAIN_NAME, username, tweetId); + return String.format(LINK_FORMAT, DOMAIN_NAME, username, tweetIdStr); } } From 8cec632b8c377c5c950f0a87d5fa0533cff4f4a2 Mon Sep 17 00:00:00 2001 From: Alex Uskov Date: Fri, 11 Oct 2024 12:26:43 +0400 Subject: [PATCH 3/4] feat(Twitter - Replace Sharing Domain): Remove useless ToString --- .../twitter/patches/links/ChangeLinkSharingDomainPatch.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java b/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java index b242571ab2..0504eddc30 100644 --- a/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java +++ b/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java @@ -11,7 +11,6 @@ public static String formatResourceLink(Object... formatArgs) { } public static String formatLink(long tweetId, String username) { - String tweetIdStr = Long.toString(tweetId); - return String.format(LINK_FORMAT, DOMAIN_NAME, username, tweetIdStr); + return String.format(LINK_FORMAT, DOMAIN_NAME, username, tweetId); } } From 4060654e66900a38ced49624a1b98121f6d5f355 Mon Sep 17 00:00:00 2001 From: oSumAtrIX Date: Thu, 17 Oct 2024 17:23:36 +0200 Subject: [PATCH 4/4] Apply suggestions from code review --- .../twitter/patches/links/ChangeLinkSharingDomainPatch.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java b/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java index 0504eddc30..943c306dfa 100644 --- a/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java +++ b/app/src/main/java/app/revanced/integrations/twitter/patches/links/ChangeLinkSharingDomainPatch.java @@ -1,8 +1,8 @@ package app.revanced.integrations.twitter.patches.links; public final class ChangeLinkSharingDomainPatch { - static final String DOMAIN_NAME = "https://fxtwitter.com"; - static final String LINK_FORMAT = "%s/%s/status/%s"; + private static final String DOMAIN_NAME = "https://fxtwitter.com"; + private static final String LINK_FORMAT = "%s/%s/status/%s"; public static String formatResourceLink(Object... formatArgs) { String username = (String) formatArgs[0];