Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should update unkeyed join error message given on #1368

Closed
MichaelChirico opened this issue Oct 1, 2015 · 1 comment
Closed

Should update unkeyed join error message given on #1368

MichaelChirico opened this issue Oct 1, 2015 · 1 comment
Assignees
Milestone

Comments

@MichaelChirico
Copy link
Member

The error message we get when we perform an unkeyed join now seems outdated:

When i is a data.table (or character vector), x must be keyed (i.e. sorted, and, marked as sorted) so data.table knows which columns to join to and take advantage of x being sorted. Call setkey(x,...) first, see ?setkey.

Since I solved my problem by simply adding on, and it seems that on is now generally the preferred approach for merges, should we not update this message?

@MichaelChirico
Copy link
Member Author

How about:

When i is a data.table (or character vector), data.table must know to which columns to join; this requires that either on is specified (see ?data.table) or x is keyed (i.e. sorted, and, marked as sorted, e.g. with setkey); there may be speed advantages if x is keyed and thus sorted.

Could also perhaps add a link to #1232 to the message, on, setkey, or some combination.

@arunsrinivasan arunsrinivasan added this to the v1.9.8 milestone Oct 6, 2015
@arunsrinivasan arunsrinivasan self-assigned this Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants