Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book 1.12.1: fov wide-angle example code is same as before #1592

Open
taehwann opened this issue Jul 30, 2024 · 0 comments
Open

Book 1.12.1: fov wide-angle example code is same as before #1592

taehwann opened this issue Jul 30, 2024 · 0 comments
Milestone

Comments

@taehwann
Copy link

Hello, I've been reading your books and it seems it has some minor issue in fov wide-angle example code.

In Listing 82: [main.cc] Scene with wide-angle camera, the book tries to show wide-angle view by setting the vfov value as 90. cam.vfov = 90;

But, when vfov is 90 deg, auto viewport_height = 2 * h * focal_length; looks same as before auto viewport_height = 2.0;

Because of tan(45 deg) = 1, and focal_length = 1.0 in Listing 82.

So, for the purpose of showing wide-angle, how about changing cam.vfov = 90 to more wide angle?

Thank you.

@hollasch hollasch added this to the Backlog milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants