We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello, I've been reading your books and it seems it has some minor issue in fov wide-angle example code.
In Listing 82: [main.cc] Scene with wide-angle camera, the book tries to show wide-angle view by setting the vfov value as 90. cam.vfov = 90;
cam.vfov = 90;
But, when vfov is 90 deg, auto viewport_height = 2 * h * focal_length; looks same as before auto viewport_height = 2.0;
auto viewport_height = 2 * h * focal_length;
auto viewport_height = 2.0;
Because of tan(45 deg) = 1, and focal_length = 1.0 in Listing 82.
tan(45 deg) = 1
focal_length = 1.0
So, for the purpose of showing wide-angle, how about changing cam.vfov = 90 to more wide angle?
cam.vfov = 90
Thank you.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hello, I've been reading your books and it seems it has some minor issue in fov wide-angle example code.
In Listing 82: [main.cc] Scene with wide-angle camera, the book tries to show wide-angle view by setting the vfov value as 90.
cam.vfov = 90;
But, when vfov is 90 deg,
auto viewport_height = 2 * h * focal_length;
looks same as beforeauto viewport_height = 2.0;
Because of
tan(45 deg) = 1
, andfocal_length = 1.0
in Listing 82.So, for the purpose of showing wide-angle, how about changing
cam.vfov = 90
to more wide angle?Thank you.
The text was updated successfully, but these errors were encountered: