Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use TemplatedNaturalLanguageGenerator in NLG due to Sanic/uvicorn conflict #4139

Closed
moaazsidat opened this issue Jul 30, 2019 · 1 comment
Labels
type:question 💬 Question around usage, examples

Comments

@moaazsidat
Copy link
Contributor

Does it make more sense to put TemplatedNaturalLanguageGenerator as part of rasa_sdk instead of rasa.core.nlg, since we're using it like so:
https://github.com/RasaHQ/rasa/blob/master/examples/nlg_server/nlg_server.py#L57

The reason being that we're using something other than Sanic for our NLG server and are running into conflicting dependencies when trying to install rasa with the latest uvicorn installation due to the following Sanic/uvicorn incompatibility:
sanic-org/sanic#1629

Anyone with more knowledge of how rasa works internally comment on if this be relatively easily extracted to be part of rasa_sdk?
https://github.com/RasaHQ/rasa/tree/master/rasa/core/nlg

Or alternatively, should there be a rasa_nlg package?

@moaazsidat moaazsidat added the type:question 💬 Question around usage, examples label Jul 30, 2019
@moaazsidat
Copy link
Contributor Author

Closing because not a question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question 💬 Question around usage, examples
Projects
None yet
Development

No branches or pull requests

1 participant