Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom header height #69

Closed
fbernack opened this issue Jan 23, 2018 · 1 comment
Closed

Custom header height #69

fbernack opened this issue Jan 23, 2018 · 1 comment

Comments

@fbernack
Copy link

Even though one should be able to define a custom header height in the ExpandingTableViewController, it seems like this value doesn't reach the TransitionDriver class. In the openBackViewConfigureConstraints function there is still the hard coded standard value '236' for the header height.

@0ber 0ber closed this as completed in 938a7a1 Jan 24, 2018
@fbernack
Copy link
Author

Thank you for the quick fix!
Since you made it clear in the comment above the headerHeight variable, that it has to be set before the animation, someone should update the project readme. In the section "Transition animation" it says you can set the value in the viewDidLoad method of your subclass which leads to the wrong behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant