Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a local git repo for e2e test #1459

Open
Tracked by #1717
par97 opened this issue Jun 14, 2024 · 2 comments
Open
Tracked by #1717

add a local git repo for e2e test #1459

par97 opened this issue Jun 14, 2024 · 2 comments
Labels
test Testing related issue

Comments

@par97
Copy link
Member

par97 commented Jun 14, 2024

Background: when we deploy argocd based application and appset, we need specify a git repo address for the application to deploy. If we have a local git server that would help reduce network risk.

Nir already has this for set up such a git server:
https://github.com/RamenDR/ramen/tree/main/test/gitlap

After the local git server is ready, we can access such a repo within the cluster like:
https://github.com/RamenDR/ramen/tree/main/test/gitlap#testing-the-server

If we clone the remote argocd example repo and push it to the local git repo, we should be able to deploy the argocd app using the local git repo instead of github using:

--repo=http://host.minikube.internal/argocd-example-apps.git

See also #1681

@par97 par97 mentioned this issue Jun 14, 2024
@ShyamsundarR
Copy link
Member

This maybe required for other tests like expanding a PVC, or expanding a StatefulSet, when the source of the PVC/STS is from git.

I would set its priority lower than other e2e tasks though at present, and come back to this as we add further test cases.

@par97
Copy link
Member Author

par97 commented Jun 14, 2024

yes, this is Nir's suggestion that we could set up such a service later. So this issue is opened for tracking purpose.

@nirs nirs added the test Testing related issue label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing related issue
Projects
None yet
Development

No branches or pull requests

3 participants