Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinecil v2: Consider changing characteristics UUIDs in BLE services #1569

Closed
marcnause opened this issue Feb 12, 2023 · 1 comment · Fixed by #1608
Closed

Pinecil v2: Consider changing characteristics UUIDs in BLE services #1569

marcnause opened this issue Feb 12, 2023 · 1 comment · Fixed by #1608
Assignees
Milestone

Comments

@marcnause
Copy link

The UUIDs of characteristics in https://github.com/Ralim/IronOS/blob/dev/source/Core/BSP/Pinecilv2/ble_characteristics.h are only unique in the scope of the different services. They are not unique in the scope of the whole device.

Also the UUIDs are 16 bit UUIDs which according to https://www.oreilly.com/library/view/getting-started-with/9781491900550/ch04.html (below headline UUID) can be used only for characteristics which are defined in the Bluetooth specification. (At least that's how I understood it, alas I am no BLE expert.)

For this reason I propose to at least consider changing the UUIDs so that the base UUID is the UUID of the respective service (128-bit UUID) as described in https://devzone.nordicsemi.com/guides/short-range-guides/b/bluetooth-low-energy/posts/ble-services-a-beginners-tutorial (below headline Universally Unique ID (UUID))

Example:

New UUID for BT_UUID_CHAR_BLE_LIVE_LIVE_TEMP: d85e0001-168e-4a71-affd-33e27f9bc533

I know that there are at least 2 clients using the Pinecil BTL services already, but since BLE support is still fairly new and there are still new features planned for IronOS v2.21, maybe now is the time to discuss this issue before more people rely on the characteristics UUIDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants