Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation files are not consistent #1253

Closed
River-Mochi opened this issue Mar 10, 2022 · 0 comments · Fixed by #1241
Closed

Translation files are not consistent #1253

River-Mochi opened this issue Mar 10, 2022 · 0 comments · Fixed by #1241
Assignees
Labels
Enhancement New feature or additional function.

Comments

@River-Mochi
Copy link
Contributor

River-Mochi commented Mar 10, 2022

Translation files are not consistent

(1)
Some translation files have code line tempUnitFahrenheit
Some have nothing, some have false, some have true

image

Details
My understanding is that temUnitFahrenheit true or false does not actually set the default temperature to C or F but merely decides if the user will be able to view a choice in the menu.

if it is set to false then users do not see any choice displayed. If it is set to True, then users have option to choose C | F

Solution:
at the minimum, all translation files should be consistent have have a code line
tempUnitFahrenheit

Perhaps add an option in the Translation editor html with a note explaining the choice:
Display choice of Celsius or Fahrenheit to all users ? yes/no check box.
If your country prefers reduced screen clutter, check No so that no choice will be displayed and everything will default to Celsius. If your country is mixed C/F then check yes, so that all users of this language will see an option in the menu to select the language they prefer.

To reduce screen clutter, many languages may desire not to display any choice in the menu as it is not needed and they will always use Celsius.

Perhaps set all Files to code line
tempUnitFahrenheit : false,

Celsius will display for everyone and if no one complains, it is done. if anyone complains we change those specific country translations to True

@River-Mochi River-Mochi added the Enhancement New feature or additional function. label Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or additional function.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants