Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VBus mod check location #1226

Closed
Ralim opened this issue Feb 12, 2022 · 2 comments
Closed

Update VBus mod check location #1226

Ralim opened this issue Feb 12, 2022 · 2 comments
Assignees
Labels
Enhancement New feature or additional function.
Milestone

Comments

@Ralim
Copy link
Owner

Ralim commented Feb 12, 2022

Need to move VBus mod probing out of debug menu or cache results to prevent timeouts with PPS.

This is basically cosmetic, it does not affect normal operation. Just that PPS times out while you view this in the debug menu if you are currently using a PPS contract.

Only issue is that the timeout means the power source will power cycle the device while you have this menu open.

@Ralim Ralim added the Enhancement New feature or additional function. label Feb 12, 2022
@Ralim Ralim added this to the 2.18 milestone Feb 12, 2022
@Ralim Ralim self-assigned this Feb 12, 2022
@River-Mochi
Copy link
Contributor

Where will the Vbus Mod probing be located now? I don't see it in the menu or is it not possible to have it due to PPS issues? thanks

@Ralim
Copy link
Owner Author

Ralim commented Feb 12, 2022

It will still show up on the debug menu when you use a pd charger. Just that I need to move the code that does this

@Ralim Ralim closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or additional function.
Projects
None yet
Development

No branches or pull requests

2 participants