Skip to content

Commit

Permalink
Auto merge of #120006 - cjgillot:no-hir-owner, r=wesleywiser
Browse files Browse the repository at this point in the history
Get rid of the hir_owner query.

This query was meant as a firewall between `hir_owner_nodes` which is supposed to change often, and the queries that only depend on the item signature. That firewall was inefficient, leaking the contents of the HIR body through `HirId`s.

`hir_owner` incurs a significant cost, as we need to hash HIR twice in multiple modes. This PR proposes to remove it, and simplify the hashing scheme.

For the future, `def_kind`, `def_span`... are much more efficient for incremental decoupling, and should be preferred.
  • Loading branch information
bors committed Jan 19, 2024
2 parents ba7d558 + 2138425 commit b2b423f
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit b2b423f

Please sign in to comment.