From ce5e999257ea6b2e086dbaf8400f3bc9325d6686 Mon Sep 17 00:00:00 2001 From: Darshan Sen Date: Wed, 26 Apr 2023 20:41:01 +0530 Subject: [PATCH] sea: move flags before code in SeaResource struct Refs: https://github.com/nodejs/node/pull/47588#discussion_r1176587438 Signed-off-by: Darshan Sen --- src/node_sea.cc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/node_sea.cc b/src/node_sea.cc index d651f6afe7f67dc..8e73f5c327856ec 100644 --- a/src/node_sea.cc +++ b/src/node_sea.cc @@ -60,8 +60,8 @@ SeaFlags operator|=(/* NOLINT (runtime/references) */ SeaFlags& x, SeaFlags y) { } struct SeaResource { - std::string_view code; SeaFlags flags = SeaFlags::kDefault; + std::string_view code; }; SeaResource FindSingleExecutableResource() { @@ -83,9 +83,13 @@ SeaResource FindSingleExecutableResource() { SeaFlags flags{ reinterpret_cast(code + sizeof(first_word))[0]}; // TODO(joyeecheung): do more checks here e.g. matching the versions. - return {{code + sizeof(first_word) + sizeof(flags), - size - sizeof(first_word) - sizeof(flags)}, - flags}; + return { + flags, + { + code + sizeof(first_word) + sizeof(flags), + size - sizeof(first_word) - sizeof(flags), + }, + }; }(); return sea_resource; }