You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue Description 🔎
Context: I've noticed a potential discrepancy in the CreateMessageRequest class within the OpenAI.Threads namespace, specifically regarding the naming of a property.
Current Implementation 🐛
The class currently has a property named fieldIds. This is highlighted in the code snippet below:
namespaceOpenAI.Threads{publicsealedclassCreateMessageRequest{// ... other properties ...[JsonPropertyName("file_ids")]publicIReadOnlyList<string>**FieldIds**{get;}// Note the naming here
Suggested Change 💡
However, based on the JsonPropertyName attribute ("file_ids"), it seems that the intended name for this property should be fileIds. This change could enhance clarity and reduce potential confusion in the code. Here's how it could look:
namespaceOpenAI.Threads{publicsealedclassCreateMessageRequest{// ... other properties ...[JsonPropertyName("file_ids")]publicIReadOnlyList<string>FileIds{get;}// Updated naming
Recommendation 📝
I recommend reviewing and possibly updating the property name to ensure it aligns with its intended purpose, enhancing code readability and maintainability.
The text was updated successfully, but these errors were encountered:
StephenHodgson
changed the title
Property Naming of CreateMessageRequest in OpenAI.Threads
parameter naming of CreateMessageRequest in OpenAI.Threads
Jan 14, 2024
Issue Description 🔎
Context: I've noticed a potential discrepancy in the CreateMessageRequest class within the OpenAI.Threads namespace, specifically regarding the naming of a property.
Current Implementation 🐛
The class currently has a property named fieldIds. This is highlighted in the code snippet below:
Suggested Change 💡
However, based on the JsonPropertyName attribute ("file_ids"), it seems that the intended name for this property should be fileIds. This change could enhance clarity and reduce potential confusion in the code. Here's how it could look:
Recommendation 📝
I recommend reviewing and possibly updating the property name to ensure it aligns with its intended purpose, enhancing code readability and maintainability.
The text was updated successfully, but these errors were encountered: