-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add benchmark repetition #27
feat: add benchmark repetition #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks for the PR
I'd just rename the "repetitions" to "repeatSuite". We run the benchmark multiple times already (benchmark runs * samples) and adding an option with that name would be misleading.
Could you also update the docs? |
Sure @RafaelGSS , I believe makes sense, I gonna update the docs and rename it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello there, this is related to this issue #6.
This PR aims to introduce benchmark repetition as an optional parameter. By running benchmarks multiple times and averaging the results, we can minimize noise and improve the accuracy of the measurements.
Below, you’ll find a comparison of benchmarks with repetition versus those without:
Let me know if need add something, thanks :)