This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
Using breakpoint instead of SIGUSR2 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SR2 to notify GDB when the offloaded program on the GPU hits a breakpoint.
…nserted in the library to trigger a stop on a GPU breakpoint.
| @@ -303,6 +303,9 @@ static struct breakpoint_ops longjmp_breakpoint_ops; | |||
| breakpoints. */ | |||
| struct breakpoint_ops bkpt_breakpoint_ops; | |||
|
|
|||
| /* The breapoint_ops structure to be used in HSA library breakpoint */ | |||
There was a problem hiding this comment.
Minor typo "breakpoint_ops"
-Updating the name of the function used to stop from TriggerStop to TriggerGPUBreakpointStop to follow the refactoring in GPUDebugSDK.
| } | ||
| ui_out_text (uiout, ", "); | ||
|
|
||
| return PRINT_SRC_AND_LOC; |
There was a problem hiding this comment.
I was trying this out internally and I noticed that it should be
"return PRINT_NOTHING".
The PRINT_SRC_AND_LOC prints information about the trigger function. I feel that the trigger is something internal to the debugger and not related to debugging the application.
nadeaudi
pushed a commit
to nadeaudi/ROCm-GDB
that referenced
this pull request
Sep 19, 2016
Using breakpoints instead of SIGUSR2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change goes with commit 6219514b827280595fc9cd5a25fcd665f8b0d35f of GPUDebugSDK for which a pull request has also been made. It modify GDB to use a breakpoint inserted inside GPUDebugSDK during initialisation to allow this library to notify GDB of GPU breakpoint stops.