Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change download_as_string to download_as_bytes in gcs submodule #571

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

alexandreyc
Copy link
Contributor

Hello,

According to the documentation of download_as_string, this method is being deprecated in favor of its alias download_as_bytes.

Here is a PR that update the related code. I also updated some broken links to the official documentation.

Alexandre

@piskvorky
Copy link
Owner

piskvorky commented Dec 28, 2020

Thanks Alexandre, much appreciated. CC @petedannemann – can you review please?

@petedannemann
Copy link
Contributor

LGTM! Nice work. Very odd that Google decided to make this fix to download_as_string and not upload_from_string

@petedannemann
Copy link
Contributor

I am confused about how coveralls is reporting that this change caused our test coverage to drop by 5.5%

@mpenkov
Copy link
Collaborator

mpenkov commented Dec 29, 2020

I think the drop in coverage is entirely unrelated to this PR.

I'm rolling out a github actions workflow to do the building and testing. Right now it's running parallel to Travis CI. I think it may be affecting the coveralls results.

@mpenkov mpenkov changed the title [GCS] Update to use download_as_bytes instead of download_as_string Change download_as_bytes to download_as_string in gcs submodule Dec 30, 2020
@mpenkov mpenkov merged commit 3927ff5 into piskvorky:develop Dec 30, 2020
@mpenkov
Copy link
Collaborator

mpenkov commented Dec 30, 2020

Merged! Thank you for the contribution, and congrats on your first smart_open PR @alexandreyc ! 🍾

@alexandreyc
Copy link
Contributor Author

Thank you all!

@mpenkov mpenkov changed the title Change download_as_bytes to download_as_string in gcs submodule Change download_as_string to download_as_bytes in gcs submodule Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants