Improve robustness of S3 reading #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
requested changes
Oct 25, 2020
There was a problem hiding this comment.
boto3 has its own retry functionality:
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/retries.html
Why not use that?
piskvorky
changed the title
mpenkov
changed the title
|
This is ready for another round @piskvorky |
mpenkov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #551
The previous implementation did a single retry without sleeping.
The proposed approach is to perform multiple retries with incremental backoff (sleep longer after consecutive failures).