Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version accounting when executing to_boto3() #539

Merged
merged 9 commits into from
Sep 25, 2020

Conversation

interpolatio
Copy link
Contributor

Title

Version accounting when executing to_boto3().

Motivation

This PR fixes the incorrect behavior of to_boto3. Now, when passing a version of an object to the to_boto3 function, the required version will be returned, not the latest.

Checklist

  • Picked a concise, informative and complete title
  • Clearly explained the motivation behind the PR
  • Linked to any existing issues that your PR will be solving
  • Included tests for any new functionality
  • Checked that all unit tests pass

interpolatio and others added 5 commits September 11, 2020 21:10
…unction to_boto3.

Added a new test for checking the receipt of boto3, taking into  the version_id.
Added an example of working with the object version for to_boto3()
@mpenkov
Copy link
Collaborator

mpenkov commented Sep 25, 2020

Thank you for your hard work @interpolatio !

@mpenkov mpenkov merged commit 2429856 into piskvorky:develop Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide public API to get version id after writing to S3
2 participants