Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement to_boto3 function for S3 I/O. #405

Merged
merged 6 commits into from
Jan 9, 2020
Merged

Implement to_boto3 function for S3 I/O. #405

merged 6 commits into from
Jan 9, 2020

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Jan 8, 2020

Motivation

Enable the use case described in #402

Checklist

Before you create the PR, please make sure you have:

  • Picked a concise, informative and complete title
  • Clearly explained the motivation behind the PR
  • Linked to any existing issues that your PR will be solving
  • Included tests for any new functionality
  • Checked that all unit tests pass

@mpenkov mpenkov requested a review from piskvorky January 8, 2020 03:26
piskvorky
piskvorky requested changes Jan 8, 2020
View reviewed changes
Copy link
Owner

@piskvorky piskvorky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's a pleasure to work with someone who can articulate and communicate clearly.

smart_open/s3.py Outdated Show resolved Hide resolved
smart_open/s3.py Outdated Show resolved Hide resolved
mpenkov and others added 2 commits January 9, 2020 21:42
@mpenkov @piskvorky
Update smart_open/s3.py
14623f3 
Co-Authored-By: Radim Řehůřek <[email protected]>
@mpenkov @piskvorky
Update smart_open/s3.py
70909df 
Co-Authored-By: Radim Řehůřek <[email protected]>
@mpenkov mpenkov merged commit a621aeb into piskvorky:master Jan 9, 2020
@mpenkov mpenkov deleted the boto3 branch January 9, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piskvorky piskvorky piskvorky requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpenkov @piskvorky